Mercurial > rsstweet

annotate app/controllers/tweets_controller.rb @ 205:8190fa511e35

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix some code style
author nanaya <me@nanaya.pro>
date Mon, 19 Oct 2020 04:09:12 +0900
parents af84c9f23263
children f9fd9d9cab97
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
1 class TweetsController < ApplicationController
38
9e03bbbb1d43 Move static#index to tweet#index.
edogawaconan <me@myconan.net>
parents: 28
diff changeset
2 def index
166
469df6354341 A more robust check
nanaya <me@nanaya.pro>
parents: 165
diff changeset
3 return redirect if params[:id].present? || params[:name].present?
38
9e03bbbb1d43 Move static#index to tweet#index.
edogawaconan <me@myconan.net>
parents: 28
diff changeset
4 end
9e03bbbb1d43 Move static#index to tweet#index.
edogawaconan <me@myconan.net>
parents: 28
diff changeset
5
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
6 def show
165
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
7 return redirect if params[:id][/D/].present?
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
8
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
9 client = Tweet.new(params[:id].to_i)
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
10 @user = client.user
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
11
203
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
12 return redirect if normalized_screen_name != params[:name]
165
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
13
86
5bfc986200db The caching becomes a bit confusing because of parameters
nanaya <me@myconan.net>
parents: 81
diff changeset
14 @tweets = client.timeline
25
70d70736faee Properly rescue 403 and 404.
edogawaconan <me@myconan.net>
parents: 15
diff changeset
15 rescue Twitter::Error::NotFound
70d70736faee Properly rescue 403 and 404.
edogawaconan <me@myconan.net>
parents: 15
diff changeset
16 head :not_found
70d70736faee Properly rescue 403 and 404.
edogawaconan <me@myconan.net>
parents: 15
diff changeset
17 rescue Twitter::Error::Unauthorized
70d70736faee Properly rescue 403 and 404.
edogawaconan <me@myconan.net>
parents: 15
diff changeset
18 head :forbidden
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
19 end
55
8f68ca606099 Add twitter id to the url so it'll be consistent.
nanaya <me@myconan.net>
parents: 48
diff changeset
20
165
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 164
diff changeset
21 def redirect
166
469df6354341 A more robust check
nanaya <me@nanaya.pro>
parents: 165
diff changeset
22 @user ||= Tweet.new(params[:id].presence || params[:name]).user
203
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
23 redirect_to tweet_path(@user.id, normalized_screen_name)
55
8f68ca606099 Add twitter id to the url so it'll be consistent.
nanaya <me@myconan.net>
parents: 48
diff changeset
24 rescue Twitter::Error::NotFound
8f68ca606099 Add twitter id to the url so it'll be consistent.
nanaya <me@myconan.net>
parents: 48
diff changeset
25 head :not_found
87
b01b5265e6d1 Whoops, forgot to rescue somewhere else
nanaya <me@myconan.net>
parents: 86
diff changeset
26 rescue Twitter::Error::Unauthorized
b01b5265e6d1 Whoops, forgot to rescue somewhere else
nanaya <me@myconan.net>
parents: 86
diff changeset
27 head :forbidden
55
8f68ca606099 Add twitter id to the url so it'll be consistent.
nanaya <me@myconan.net>
parents: 48
diff changeset
28 end
203
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
29
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
30 private
205
8190fa511e35 Fix some code style
nanaya <me@nanaya.pro>
parents: 203
diff changeset
31
203
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
32 def normalized_screen_name
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
33 @user.screen_name.presence || '_'
af84c9f23263 Fix redirect for twitter user with nil screen name
nanaya <me@nanaya.pro>
parents: 166
diff changeset
34 end
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
35 end