annotate app/models/tweet.rb @ 172:df4be896ab8b

Improved escaping and truncating
author nanaya <me@nanaya.pro>
date Wed, 08 Aug 2018 20:37:29 +0900
parents 5af9b537db86
children 08cc4a4d8a5f
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
1 class Tweet
137
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
2 TIMELINE_OPTIONS = {
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
3 :count => 100,
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
4 :exclude_replies => false,
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
5 :include_rts => true,
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
6 :tweet_mode => :extended,
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
7 }
00dc9346dfaa Skip self retweets
nanaya <me@nanaya.pro>
parents: 136
diff changeset
8
158
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
9 def self.cache_expires_time
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
10 (15 + rand(15)).minutes
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
11 end
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
12
135
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
13 def initialize(twitter_id)
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
14 @clients = {}
165
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 163
diff changeset
15 @twitter_id = twitter_id
135
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
16 end
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
17
158
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
18 def id
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
19 user.id
152
fd7344643903 Better? cache key
nanaya <me@nanaya.pro>
parents: 146
diff changeset
20 end
fd7344643903 Better? cache key
nanaya <me@nanaya.pro>
parents: 146
diff changeset
21
86
5bfc986200db The caching becomes a bit confusing because of parameters
nanaya <me@myconan.net>
parents: 78
diff changeset
22 def timeline
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
23 if @timeline.nil?
158
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
24 cache_key = "timeline:v2:#{id}/#{Base64.urlsafe_encode64 id.to_s}"
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
25 raw = Rails.cache.fetch(cache_key, :expires_in => self.class.cache_expires_time) do
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
26 client_try(:user_timeline, id, TIMELINE_OPTIONS).tap do |data|
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
27 if data[:result] == :ok
158
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
28 if data[:data].any? && data[:data].first.user.id != id
146
7ca8aeba1a63 Try tracing where the failures happen
nanaya <me@nanaya.pro>
parents: 145
diff changeset
29 wrong_user = data[:data].first.user
160
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
30 throw "Wrong timeline data. Requested: #{id}, got: #{wrong_user.id} (#{wrong_user.screen_name.printable})"
146
7ca8aeba1a63 Try tracing where the failures happen
nanaya <me@nanaya.pro>
parents: 145
diff changeset
31 end
7ca8aeba1a63 Try tracing where the failures happen
nanaya <me@nanaya.pro>
parents: 145
diff changeset
32
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
33 data[:data] = data[:data].select do |tweet|
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
34 tweet.retweeted_status.nil? || tweet.user.id != tweet.retweeted_status.user.id
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
35 end.map { |tweet| tweet.to_h }
134
3646b3e319c7 Only try/catch the tweet downloading part
nanaya <me@nanaya.pro>
parents: 108
diff changeset
36 end
76
0c023d35cd80 Allows usage of multiple twitter keys
nanaya <me@myconan.net>
parents: 73
diff changeset
37 end
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
38 end
141
88d7a7714d4e Restrict to just the fetch process
nanaya <me@nanaya.pro>
parents: 138
diff changeset
39
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
40 raise Twitter::Error::NotFound if raw[:result] == :not_found
144
1925b08153dc Record 404s
nanaya <me@nanaya.pro>
parents: 143
diff changeset
41
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
42 @timeline = raw[:data].map { |tweet_hash| Twitter::Tweet.new(tweet_hash) }
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
43 end
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
44
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
45 @timeline
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
46 end
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
47
48
8983c426e256 Prevent exploding on empty timeline.
nanaya <me@myconan.net>
parents: 47
diff changeset
48 def user
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
49 if @user.nil?
165
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 163
diff changeset
50 cache_key = "user:v1:#{@twitter_id.is_a?(Integer) ? 'id' : 'lookup'}:#{@twitter_id}"
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 163
diff changeset
51 raw = Rails.cache.fetch(cache_key, :expires_in => self.class.cache_expires_time) do
160
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
52 client_try(:user, @twitter_id).tap do |data|
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
53 if data[:result] == :ok
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
54 user = data[:data]
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
55
165
5af9b537db86 Unbreak \everything/
nanaya <me@nanaya.pro>
parents: 163
diff changeset
56 if user.id != @twitter_id && user.screen_name.downcase != @twitter_id
160
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
57 throw "Wrong user data. Requested: #{@twitter_id}, got: #{user.id} (#{user.screen_name.printable})"
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
58 end
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
59 end
4e4195e60c2b Add check at user level as well
nanaya <me@nanaya.pro>
parents: 158
diff changeset
60 end
48
8983c426e256 Prevent exploding on empty timeline.
nanaya <me@myconan.net>
parents: 47
diff changeset
61 end
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
62
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
63 raise Twitter::Error::NotFound if raw[:result] == :not_found
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
64
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
65 @user = raw[:data]
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
66 end
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
67
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
68 @user
48
8983c426e256 Prevent exploding on empty timeline.
nanaya <me@myconan.net>
parents: 47
diff changeset
69 end
8983c426e256 Prevent exploding on empty timeline.
nanaya <me@myconan.net>
parents: 47
diff changeset
70
135
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
71 def client
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
72 @clients[client_config_id] ||=
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
73 Twitter::REST::Client.new do |config|
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
74 $cfg[:twitter][client_config_id].each do |cfg_key, cfg_value|
138
7907fe886675 Better use symbol?
nanaya <me@nanaya.pro>
parents: 137
diff changeset
75 config.public_send(:"#{cfg_key}=", cfg_value)
135
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
76 end
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
77 end
76
0c023d35cd80 Allows usage of multiple twitter keys
nanaya <me@myconan.net>
parents: 73
diff changeset
78 end
0c023d35cd80 Allows usage of multiple twitter keys
nanaya <me@myconan.net>
parents: 73
diff changeset
79
145
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
80 def client_try(method, *args)
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
81 initial_config_id = client_config_id
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
82
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
83 begin
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
84 data = client.public_send method, *args
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
85 rescue Twitter::Error::TooManyRequests
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
86 @client_config_id += 1
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
87
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
88 if initial_config_id == client_config_id
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
89 raise
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
90 else
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
91 retry
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
92 end
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
93 rescue Twitter::Error::NotFound
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
94 return { :result => :not_found }
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
95 end
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
96
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
97 { :result => :ok, :data => data }
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
98 end
c791b6bfeeda More refactors
nanaya <me@nanaya.pro>
parents: 144
diff changeset
99
135
3fc882b0884d Refactored client initialization
nanaya <me@nanaya.pro>
parents: 134
diff changeset
100 def client_config_id
158
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
101 @client_config_count ||= $cfg[:twitter].size
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
102 @client_config_id ||= rand(@client_config_count)
76
0c023d35cd80 Allows usage of multiple twitter keys
nanaya <me@myconan.net>
parents: 73
diff changeset
103
158
74422bae017d Always use canonical id and turn cache time generator a class method
nanaya <me@nanaya.pro>
parents: 157
diff changeset
104 @client_config_id %= @client_config_count
15
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
105 end
207917e41964 Add tweets~
edogawaconan <me@myconan.net>
parents:
diff changeset
106 end